JSON schema for mcpfile #155
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
.github/workflows/verify-codegen.yaml (1)
32-51: Apply shellcheck recommendations for robustness.The verification logic is correct, but shellcheck has identified several style and robustness issues:
- Use
$(...)notation instead of legacy backticks- Quote variables to prevent globbing and word splitting
Apply this diff to address the shellcheck issues:
if [[ -z "$(git status --porcelain)" ]]; then echo "${{ github.repository }} up to date." else # Print it both ways because sometimes we haven't modified the file (e.g. zz_generated), # and sometimes we have (e.g. configmap checksum). - echo "Found diffs in: $(git diff-index --name-only HEAD --)" - for x in $(git diff-index --name-only HEAD --); do - echo "::error file=$x::Please run `make update-codegen`.%0A$(git diff $x | urlencode)" + echo "Found diffs in: $(git diff-index --name-only HEAD --)" + for x in $(git diff-index --name-only HEAD --); do + echo "::error file=$x::Please run \`make update-codegen\`.%0A$(git diff "$x" | urlencode)" done echo "${{ github.repository }} is out of date. Please run \`make update-codegen\`" exit 1 fiNote: The backticks in the error message string are already escaped, but the command substitution on line 47 should use
$(git diff "$x" | urlencode)instead of backticks, and$xshould be quoted.Based on static analysis hints.
mcpfile-schema.json (1)
381-386: Add placeholder comment for StdioConfig
StdioConfig is currently an empty marker type. If it’s intended as a placeholder for future stdio transport options, update the Go struct’s doc comment (e.g. “// Placeholder for future stdio configuration options”) to make this explicit.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
hack/jsonschemagen/go.sumis excluded by!**/*.sumhack/jsonschemagen/mcpfile-autocomplete-screenshot.pngis excluded by!**/*.png
📒 Files selected for processing (24)
.github/workflows/verify-codegen.yaml(1 hunks)Makefile(1 hunks)README.md(1 hunks)examples/http-conversion/feature-requests/mcpfile-localhost.yaml(1 hunks)examples/http-conversion/feature-requests/mcpfile.yaml(1 hunks)examples/http-conversion/mcpfile.yaml(1 hunks)examples/http-conversion/oauth-mcpfile.yaml(1 hunks)hack/jsonschemagen/README.md(1 hunks)hack/jsonschemagen/go.mod(1 hunks)hack/jsonschemagen/main.go(1 hunks)hack/library.sh(1 hunks)hack/update-codegen.sh(1 hunks)mcpfile-schema.json(1 hunks)pkg/mcpfile/testdata/full-demo.yaml(1 hunks)pkg/mcpfile/testdata/no-servers.yaml(1 hunks)pkg/mcpfile/testdata/one-server-cli-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-no-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-prompts.yaml(1 hunks)pkg/mcpfile/testdata/one-server-stateful.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tls.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools-http-params.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools.yaml(1 hunks)pkg/mcpfile/testdata/server-runtime-stdio.yaml(1 hunks)pkg/mcpfile/types.go(4 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/verify-codegen.yaml
32-32: shellcheck reported issue in this script: SC2006:style:15:43: Use $(...) notation instead of legacy backticks ...
(shellcheck)
32-32: shellcheck reported issue in this script: SC2086:info:15:79: Double quote to prevent globbing and word splitting
(shellcheck)
32-32: shellcheck reported issue in this script: SC2006:style:17:63: Use $(...) notation instead of legacy backticks ...
(shellcheck)
🪛 Shellcheck (0.11.0)
hack/library.sh
[warning] 5-5: ROOT_DIR appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 11-11: Declare and assign separately to avoid masking return values.
(SC2155)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Unit Tests
🔇 Additional comments (3)
hack/jsonschemagen/main.go (1)
14-32: LGTM! Schema generation logic is sound.The schema generation workflow is well-structured with proper error handling at each step. The relative paths for package location and output file assume execution from
hack/jsonschemagen/, which should work correctly when invoked via the documented build scripts.mcpfile-schema.json (2)
1-4: LGTM! Schema metadata is correctly structured.The schema uses JSON Schema Draft 2020-12 and properly references the root MCPFile definition.
24-65: LGTM! MCPFile root schema is well-structured.The schema correctly defines required fields (
mcpFileVersion,name,version) and optional collections (tools,prompts), withadditionalProperties: falsefor strict validation.
|
@aliok can we also add this annotation as a comment to the top of the converted mcpfiles ? I'm fine with that being either in this PR or in a follow up |
aliok
force-pushed
the
2025-10-07-json-schema
branch
from
3db4435 to
eab4c56
Compare
WalkthroughAdds JSON Schema generation for MCP types, CI verification for generated schema, Makefile integration, CLI schema header injection, expanded public MCP types with jsonschema tags, generated schema artifacts under Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant GA as GitHub Actions
participant Make as make
participant Gen as jsonschemagen (go run)
participant Repo as specs/
Dev->>GA: Push / PR
GA->>Make: make update-codegen
Make->>Gen: go run hack/jsonschemagen/main.go
Gen->>Repo: Write mcpfile-schema-<version>.json
Gen->>Repo: Write mcpfile-schema.json (latest)
GA->>GA: git diff
alt No changes
GA-->>Dev: "Repository up to date"
else Changes detected
GA-->>Dev: Annotated errors with diffs
GA-->>Dev: Fail job
end
sequenceDiagram
autonumber
participant User as User
participant CLI as gen-mcp CLI
participant Util as utils.AppendSchemaHeader
participant FS as Filesystem
User->>CLI: Convert config -> MCP YAML
CLI->>CLI: Marshal MCPFile to YAML
CLI->>Util: AppendSchemaHeader(bytes)
Util-->>CLI: YAML with `# yaml-language-server: $schema=...` prefixed
CLI->>FS: Write YAML with schema header
CLI-->>User: Output file
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (1)
pkg/mcpfile/types.go (1)
132-140: Makestatelessoptional to match actual configs.
StreamableHTTPConfig.Statelessis still taggedjsonschema:"required". Our YAML/JSON readers happily omit this field (it defaults tofalse), so the generated schema now rejects valid MCP files. Drop therequiredtag and addomitemptyto the JSON tag so the schema reflects reality.- // Indicates whether the server is stateless. - Stateless bool `json:"stateless" jsonschema:"required"` + // Indicates whether the server is stateless. + Stateless bool `json:"stateless,omitempty" jsonschema:"optional"`
🧹 Nitpick comments (2)
README.md (1)
144-161: Consider recommending versioned schema URL.The documentation is clear and helpful. However, the example schema URL points to
refs/heads/mainwhich references the unstable main branch:# yaml-language-server: $schema=https://raw.githubusercontent.com/genmcp/gen-mcp/refs/heads/main/specs/mcpfile-schema.jsonFor production use, consider also documenting a versioned approach:
- Reference a specific release tag:
refs/tags/v0.1.0/specs/mcpfile-schema-0.1.0.json- Or use a "latest" symlink if available:
specs/mcpfile-schema-latest.jsonThis prevents schema changes on
mainfrom unexpectedly affecting existing projects.Alternatively, you could add a note recommending users pin to a specific version in production environments.
.github/workflows/verify-codegen.yaml (1)
32-51: Improve shell script robustness.The verification script has minor shell style and safety issues flagged by shellcheck:
- Legacy backtick syntax on Lines 45 and 46
- Unquoted variable expansion on Line 45 could cause word splitting/globbing issues
Apply this diff to address the shellcheck warnings:
if [[ -z "$(git status --porcelain)" ]]; then echo "${{ github.repository }} up to date." else # Print it both ways because sometimes we haven't modified the file (e.g. zz_generated), # and sometimes we have (e.g. configmap checksum). - echo "Found diffs in: $(git diff-index --name-only HEAD --)" - for x in $(git diff-index --name-only HEAD --); do + echo "Found diffs in: $(git diff-index --name-only HEAD --)" + while IFS= read -r x; do echo "::error file=$x::Please run \`make update-codegen\`.%0A$(git diff $x | urlencode)" - done + done < <(git diff-index --name-only HEAD --) echo "${{ github.repository }} is out of date. Please run \`make update-codegen\`" exit 1 fiThis refactor:
- Keeps modern command substitution syntax
$(...)(already in use on Line 45)- Replaces the
for x in $(...)loop with a saferwhile readpattern that handles filenames with spaces correctly
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
hack/jsonschemagen/go.sumis excluded by!**/*.sumhack/jsonschemagen/mcpfile-autocomplete-screenshot.pngis excluded by!**/*.png
📒 Files selected for processing (29)
.github/workflows/verify-codegen.yaml(1 hunks)Makefile(1 hunks)README.md(1 hunks)examples/http-conversion/feature-requests/mcpfile-localhost.yaml(1 hunks)examples/http-conversion/feature-requests/mcpfile.yaml(1 hunks)examples/http-conversion/mcpfile.yaml(1 hunks)examples/http-conversion/oauth-mcpfile.yaml(1 hunks)hack/jsonschemagen/README.md(1 hunks)hack/jsonschemagen/go.mod(1 hunks)hack/jsonschemagen/main.go(1 hunks)hack/update-codegen.sh(1 hunks)pkg/cli/convert-cli.go(2 hunks)pkg/cli/convert.go(2 hunks)pkg/cli/utils/schema.go(1 hunks)pkg/invocation/cli/config.go(3 hunks)pkg/invocation/http/config.go(1 hunks)pkg/mcpfile/testdata/full-demo.yaml(1 hunks)pkg/mcpfile/testdata/no-servers.yaml(1 hunks)pkg/mcpfile/testdata/one-server-cli-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-no-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-prompts.yaml(1 hunks)pkg/mcpfile/testdata/one-server-stateful.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tls.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools-http-params.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools.yaml(1 hunks)pkg/mcpfile/testdata/server-runtime-stdio.yaml(1 hunks)pkg/mcpfile/types.go(4 hunks)specs/mcpfile-schema-0.1.0.json(1 hunks)specs/mcpfile-schema.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-07T17:29:19.408Z
Learnt from: Cali0707
PR: genmcp/gen-mcp#155
File: hack/jsonschemagen/go.mod:3-8
Timestamp: 2025-10-07T17:29:19.408Z
Learning: The gen-mcp project targets Go 1.24+ and does not require backward compatibility with Go 1.21.
Applied to files:
hack/jsonschemagen/go.mod
🧬 Code graph analysis (5)
pkg/cli/convert-cli.go (1)
pkg/cli/utils/schema.go (1)
AppendSchemaHeader(9-16)
pkg/cli/convert.go (1)
pkg/cli/utils/schema.go (1)
AppendSchemaHeader(9-16)
hack/update-codegen.sh (1)
hack/lib/common.sh (1)
header_text(12-14)
pkg/cli/utils/schema.go (1)
pkg/mcpfile/types.go (1)
MCPFileVersion(10-10)
hack/jsonschemagen/main.go (3)
pkg/mcpfile/types.go (2)
MCPFile(200-206)MCPFileVersion(10-10)pkg/invocation/http/config.go (1)
HttpInvocationData(23-26)pkg/invocation/cli/config.go (1)
CliInvocationData(11-14)
🪛 actionlint (1.7.7)
.github/workflows/verify-codegen.yaml
32-32: shellcheck reported issue in this script: SC2006:style:15:43: Use $(...) notation instead of legacy backticks ...
(shellcheck)
32-32: shellcheck reported issue in this script: SC2086:info:15:79: Double quote to prevent globbing and word splitting
(shellcheck)
32-32: shellcheck reported issue in this script: SC2006:style:17:63: Use $(...) notation instead of legacy backticks ...
(shellcheck)
🪛 markdownlint-cli2 (0.18.1)
hack/jsonschemagen/README.md
41-41: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (25)
examples/http-conversion/oauth-mcpfile.yaml (1)
1-1: LGTM! Schema directive correctly configured.The YAML language server directive enables IDE autocompletion and validation. The relative path
../../specs/mcpfile-schema.jsoncorrectly resolves fromexamples/http-conversion/to the repository rootspecs/directory.examples/http-conversion/feature-requests/mcpfile-localhost.yaml (2)
1-1: Schema directive correctly configured.The relative path
../../../specs/mcpfile-schema.jsoncorrectly resolves fromexamples/http-conversion/feature-requests/to the repository rootspecs/directory.
9-17: AI summary inconsistency: tool is still present.The AI-generated summary claims a tool was removed ("Returns a list of all features sorted by upvotes (highest first)"), but this tool is still present in the code at lines 9-17 with name
features-get. The provided code shows the final state after changes, so the summary appears incorrect.hack/jsonschemagen/go.mod (1)
1-23: LGTM! Module configuration aligns with project standards.The Go version
1.24.7is appropriate for this project, as the gen-mcp project targets Go 1.24+ (per retrieved learnings). The module structure is correct:
- Replace directive properly references the parent repository
- Dependencies are appropriate for JSON schema generation (invopop/jsonschema)
- Indirect dependencies are properly listed
Based on learnings.
pkg/invocation/cli/config.go (3)
16-28: LGTM! Well-documented schema metadata.The addition of
jsonschematags enables proper JSON schema generation. The comments clearly explain field purposes, andParameterIndicesis appropriately marked as internal withjson:"-"and a clear explanation.
40-52: LGTM! Clear schema annotations.The
jsonschematags properly document required vs. optional fields. Comments provide helpful context about field usage, including the example of"--user=%s"or"--verbose".
60-65: LGTM! Improved type safety.The safe type assertion
b, ok := value.(bool)prevents panics when the value is not a boolean. This is a good defensive programming practice.pkg/mcpfile/testdata/one-server-tools-http-params.yaml (1)
1-1: LGTM! Test data now schema-validated.Adding the schema directive to test data helps ensure test files remain valid as the schema evolves. The relative path correctly resolves to the repository root
specs/directory.pkg/mcpfile/testdata/no-servers.yaml (1)
1-1: LGTM! Minimal test case includes schema validation.Even this minimal test file benefits from schema validation, ensuring the bare minimum configuration remains valid.
pkg/mcpfile/testdata/one-server-stateful.yaml (1)
1-1: LGTM! Test data aligns with schema and code changes.The schema directive enables validation for this CLI invocation test case. The file content at lines 30-37 demonstrates the
templateVariablesfeature that now has proper JSON schema support via the changes inpkg/invocation/cli/config.go.pkg/mcpfile/testdata/one-server-tools.yaml (1)
1-1: LGTM! Schema directive correctly added.The YAML language server directive enables editor validation and autocompletion without affecting runtime behavior.
pkg/mcpfile/testdata/one-server-tls.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive enables schema-based editor tooling without modifying the file's runtime semantics.
pkg/mcpfile/testdata/server-runtime-stdio.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive enables schema-based editor tooling.
Note: The AI summary mentions removal of the
clone_repotool, but it is still present in the provided code (lines 8-33).pkg/mcpfile/testdata/one-server-cli-tools.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive is consistent with other testdata files and enables editor validation.
pkg/mcpfile/testdata/one-server-no-tools.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive aligns with the schema integration pattern across testdata files.
pkg/mcpfile/testdata/one-server-prompts.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive is properly formatted and consistent with the schema integration approach.
examples/http-conversion/feature-requests/mcpfile.yaml (1)
1-1: LGTM! Schema directive correctly added.The directive extends schema validation to example files, maintaining consistency with testdata.
pkg/cli/convert-cli.go (1)
7-7: LGTM! Import correctly added.The utils package import is necessary for the schema header functionality.
pkg/cli/convert.go (1)
62-63: LGTM!The schema header is correctly appended to the marshalled MCP file bytes before writing to disk, ensuring generated YAML files include the yaml-language-server directive for IDE support.
pkg/mcpfile/testdata/full-demo.yaml (1)
1-1: LGTM!The schema header is correctly added with an appropriate relative path for testdata files, enabling IDE validation and autocomplete for this example mcpfile.
examples/http-conversion/mcpfile.yaml (2)
1-1: LGTM!The schema header is correctly added with an appropriate relative path for example files.
8-86: Summary inconsistency detected.The AI-generated summary claims "Removed all tool definitions under the 'tools' section (six tools removed...)", but the provided code clearly shows 6 tool definitions still present (get_features, post_features, get_features-top, get_features-id, post_features-vote, post_features-complete).
hack/update-codegen.sh (1)
1-13: LGTM!The codegen script is well-structured with proper error handling (
set -eandset -o pipefail), clean directory navigation usingpushd/popd, and appropriate status output using theheader_texthelper from common.sh.Makefile (2)
25-29: LGTM!The new
update-codegentarget is well-defined and provides clear status messages.
32-32: LGTM!Adding
update-codegenas a prerequisite forbuild-cliensures the schema is always up-to-date before building the CLI, preventing potential inconsistencies.
|
@aliok can you fix the merge conflicts on this? |
aliok
force-pushed
the
2025-10-07-json-schema
branch
from
eab4c56 to
ef793cb
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
pkg/mcpfile/types.go (1)
227-243: Makestatelessoptional again.Keeping
statelessmarkedjsonschema:"required"means every MCP file must now set it, yet none of our shipped examples do. Validation will fail for real configs. Please drop therequiredtag and addomitemptyto the JSON tag so existing files stay valid.Apply this diff:
type StreamableHTTPConfig struct { // Port number to listen on. Port int `json:"port" jsonschema:"required"` @@ - // Indicates whether the server is stateless. - Stateless bool `json:"stateless" jsonschema:"required"` + // Indicates whether the server is stateless. + Stateless bool `json:"stateless,omitempty" jsonschema:"optional"`pkg/invocation/cli/config.go (1)
10-14: Rename theCliInvocationDatafield to match its content.The field holds CLI config but is still called
Http, which is confusing and contradicts thejson:"cli"tag. Please rename it toCli(and update call sites) so the API reflects its purpose.Suggested change:
type CliInvocationData struct { // Detailed CLI invocation configuration. - Http CliInvocationConfig `json:"cli" jsonschema:"required"` + Cli CliInvocationConfig `json:"cli" jsonschema:"required"` }hack/jsonschemagen/README.md (1)
41-45: Add a language hint to the directory tree blockPlease tag this fenced block with a language (e.g. ```text) so markdownlint stops flagging it and the tree renders correctly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
hack/jsonschemagen/go.sumis excluded by!**/*.sumhack/jsonschemagen/mcpfile-autocomplete-screenshot.pngis excluded by!**/*.png
📒 Files selected for processing (29)
.github/workflows/verify-codegen.yaml(1 hunks)Makefile(1 hunks)README.md(1 hunks)examples/http-conversion/feature-requests/mcpfile-localhost.yaml(1 hunks)examples/http-conversion/feature-requests/mcpfile.yaml(1 hunks)examples/http-conversion/mcpfile.yaml(1 hunks)examples/http-conversion/oauth-mcpfile.yaml(1 hunks)hack/jsonschemagen/README.md(1 hunks)hack/jsonschemagen/go.mod(1 hunks)hack/jsonschemagen/main.go(1 hunks)hack/update-codegen.sh(1 hunks)pkg/cli/convert-cli.go(2 hunks)pkg/cli/convert.go(2 hunks)pkg/cli/utils/schema.go(1 hunks)pkg/invocation/cli/config.go(3 hunks)pkg/invocation/http/config.go(1 hunks)pkg/mcpfile/testdata/full-demo.yaml(1 hunks)pkg/mcpfile/testdata/no-servers.yaml(1 hunks)pkg/mcpfile/testdata/one-server-cli-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-no-tools.yaml(1 hunks)pkg/mcpfile/testdata/one-server-prompts.yaml(1 hunks)pkg/mcpfile/testdata/one-server-stateful.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tls.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools-http-params.yaml(1 hunks)pkg/mcpfile/testdata/one-server-tools.yaml(1 hunks)pkg/mcpfile/testdata/server-runtime-stdio.yaml(1 hunks)pkg/mcpfile/types.go(6 hunks)specs/mcpfile-schema-0.1.0.json(1 hunks)specs/mcpfile-schema.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- pkg/mcpfile/testdata/one-server-tools.yaml
- examples/http-conversion/oauth-mcpfile.yaml
🚧 Files skipped from review as they are similar to previous changes (18)
- examples/http-conversion/feature-requests/mcpfile.yaml
- pkg/mcpfile/testdata/one-server-prompts.yaml
- pkg/mcpfile/testdata/no-servers.yaml
- examples/http-conversion/feature-requests/mcpfile-localhost.yaml
- pkg/mcpfile/testdata/one-server-no-tools.yaml
- pkg/cli/convert.go
- hack/jsonschemagen/main.go
- Makefile
- examples/http-conversion/mcpfile.yaml
- pkg/mcpfile/testdata/server-runtime-stdio.yaml
- pkg/cli/utils/schema.go
- pkg/mcpfile/testdata/one-server-stateful.yaml
- hack/jsonschemagen/go.mod
- pkg/cli/convert-cli.go
- pkg/mcpfile/testdata/one-server-tools-http-params.yaml
- pkg/mcpfile/testdata/one-server-tls.yaml
- pkg/mcpfile/testdata/full-demo.yaml
- README.md
🧰 Additional context used
🧬 Code graph analysis (1)
hack/update-codegen.sh (1)
hack/lib/common.sh (1)
header_text(12-14)
🪛 actionlint (1.7.7)
.github/workflows/verify-codegen.yaml
32-32: shellcheck reported issue in this script: SC2006:style:15:43: Use $(...) notation instead of legacy backticks ...
(shellcheck)
32-32: shellcheck reported issue in this script: SC2086:info:15:79: Double quote to prevent globbing and word splitting
(shellcheck)
32-32: shellcheck reported issue in this script: SC2006:style:17:63: Use $(...) notation instead of legacy backticks ...
(shellcheck)
🪛 markdownlint-cli2 (0.18.1)
hack/jsonschemagen/README.md
34-34: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
44-44: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Unit Tests
|
@Cali0707 no more conflicts |
| "oneOf": [ | ||
| { | ||
| "$ref": "#/$defs/HttpInvocationData" | ||
| }, | ||
| { | ||
| "$ref": "#/$defs/CliInvocationData" | ||
| } |
There was a problem hiding this comment.
Woohoo this is awesome @aliok 🎉
2 participants
Fixes #140
Instructions to test it:
Create an
mcpfile.yamlthat starts like thisSummary by CodeRabbit
New Features
Documentation
Chores
Examples