Skip to content

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Aug 25, 2025

Description

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--891.org.readthedocs.build/en/891/
💡 JupyterLite preview: https://jupytergis--891.org.readthedocs.build/en/891/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/save_to_db

@gjmooney gjmooney mentioned this pull request Aug 25, 2025
4 tasks
@gjmooney gjmooney added the bug Something isn't working label Aug 25, 2025
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Thanks

@martinRenou
Copy link
Member

Thanks @gjmooney !

We should discuss this, I have some concerns. We used to save the geotiff content into indexeddb, but it was removed as part of #503.

The issue is that OpenLayers supports COG properly, it only downloads what it needs for rendering, but we were downloading the full geotiff content (could be gigs of data!)

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting my veto on this for now

Copy link
Contributor

Integration tests report: appsharing.space

@martinRenou
Copy link
Member

I may be misunderstanding the PR here. In which case are we using this loadGeoTiff logic? Is it only for local files that do not support COG?

@mfisher87 mfisher87 changed the title Save geotiff files to indexeddb Save geotiff files and metadata to indexeddb Aug 25, 2025
@mfisher87
Copy link
Member

In which case are we using this loadGeoTiff logic? Is it only for local files that do not support COG?

If this is the case, let's update the name!

For COGs over HTTP, I think the only thing we should be caching is the min and maximum values. Maybe all the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants