-
Notifications
You must be signed in to change notification settings - Fork 56
Save geotiff files and metadata to indexeddb #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 Thanks
Thanks @gjmooney ! We should discuss this, I have some concerns. We used to save the geotiff content into indexeddb, but it was removed as part of #503. The issue is that OpenLayers supports COG properly, it only downloads what it needs for rendering, but we were downloading the full geotiff content (could be gigs of data!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting my veto on this for now
Integration tests report: appsharing.space |
I may be misunderstanding the PR here. In which case are we using this |
If this is the case, let's update the name! For COGs over HTTP, I think the only thing we should be caching is the min and maximum values. Maybe all the metadata. |
Description
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--891.org.readthedocs.build/en/891/
💡 JupyterLite preview: https://jupytergis--891.org.readthedocs.build/en/891/lite