Skip to content

chore: Remove dangling experimental metrics classes #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

chore: Remove dangling experimental metrics classes #4410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c153f8d
chore: Remove dangling experimental metrics classes
jamescrosswell Aug 5, 2025
c5f857a
Merge branch 'main' into remove-experimental-metrics
jamescrosswell Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 0 additions & 249 deletions src/Sentry/BuiltInSystemDiagnosticsMeters.cs
View file
Open in desktop

This file was deleted.

61 changes: 0 additions & 61 deletions src/Sentry/ExperimentalMetricsOptions.cs
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,6 @@ namespace Sentry
[System.Runtime.Serialization.EnumMember(Value="critical")]
Critical = 3,
}
public static class BuiltInSystemDiagnosticsMeters
{
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreDiagnostics;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHeaderParsing;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHosting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHttpConnections;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreRateLimiting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreRouting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreServerKestrel;
public static readonly Sentry.StringOrRegex MicrosoftExtensionsDiagnosticsHealthChecks;
public static readonly Sentry.StringOrRegex MicrosoftExtensionsDiagnosticsResourceMonitoring;
public static readonly Sentry.StringOrRegex OpenTelemetryInstrumentationRuntime;
public static readonly Sentry.StringOrRegex SystemNetHttp;
public static readonly Sentry.StringOrRegex SystemNetNameResolution;
public static System.Collections.Generic.IList<Sentry.StringOrRegex> All { get; }
}
public class ByteAttachmentContent : Sentry.IAttachmentContent
{
public ByteAttachmentContent(byte[] bytes) { }
Expand Down Expand Up @@ -112,13 +96,6 @@ namespace Sentry
public static void SetFingerprint(this Sentry.IEventLike eventLike, System.Collections.Generic.IEnumerable<string> fingerprint) { }
public static void SetFingerprint(this Sentry.IEventLike eventLike, params string[] fingerprint) { }
}
public class ExperimentalMetricsOptions
{
public ExperimentalMetricsOptions() { }
public System.Collections.Generic.IList<Sentry.StringOrRegex> CaptureSystemDiagnosticsInstruments { get; set; }
public System.Collections.Generic.IList<Sentry.StringOrRegex> CaptureSystemDiagnosticsMeters { get; set; }
public bool EnableCodeLocations { get; set; }
}
public class FileAttachmentContent : Sentry.IAttachmentContent
{
public FileAttachmentContent(string filePath) { }
Expand Down
23 changes: 0 additions & 23 deletions test/Sentry.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,6 @@ namespace Sentry
[System.Runtime.Serialization.EnumMember(Value="critical")]
Critical = 3,
}
public static class BuiltInSystemDiagnosticsMeters
{
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreDiagnostics;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHeaderParsing;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHosting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreHttpConnections;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreRateLimiting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreRouting;
public static readonly Sentry.StringOrRegex MicrosoftAspNetCoreServerKestrel;
public static readonly Sentry.StringOrRegex MicrosoftExtensionsDiagnosticsHealthChecks;
public static readonly Sentry.StringOrRegex MicrosoftExtensionsDiagnosticsResourceMonitoring;
public static readonly Sentry.StringOrRegex OpenTelemetryInstrumentationRuntime;
public static readonly Sentry.StringOrRegex SystemNetHttp;
public static readonly Sentry.StringOrRegex SystemNetNameResolution;
public static System.Collections.Generic.IList<Sentry.StringOrRegex> All { get; }
}
public class ByteAttachmentContent : Sentry.IAttachmentContent
{
public ByteAttachmentContent(byte[] bytes) { }
Expand Down Expand Up @@ -112,13 +96,6 @@ namespace Sentry
public static void SetFingerprint(this Sentry.IEventLike eventLike, System.Collections.Generic.IEnumerable<string> fingerprint) { }
public static void SetFingerprint(this Sentry.IEventLike eventLike, params string[] fingerprint) { }
}
public class ExperimentalMetricsOptions
{
public ExperimentalMetricsOptions() { }
public System.Collections.Generic.IList<Sentry.StringOrRegex> CaptureSystemDiagnosticsInstruments { get; set; }
public System.Collections.Generic.IList<Sentry.StringOrRegex> CaptureSystemDiagnosticsMeters { get; set; }
public bool EnableCodeLocations { get; set; }
}
public class FileAttachmentContent : Sentry.IAttachmentContent
{
public FileAttachmentContent(string filePath) { }
Expand Down
Loading
Loading