Skip to content

Send Timber logs through Sentry Logs #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: feat/logcat-sentry-logs
Choose a base branch
from
Open

Send Timber logs through Sentry Logs #4490

wants to merge 3 commits into from

Conversation

stefanosiano
Copy link
Member

📜 Description

Logs captured by Timber are now sent as Sentry Logs

💡 Motivation and Context

Closes #4407

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d82553f

stefanosiano
stefanosiano commented Jun 13, 2025
View reviewed changes
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
@@ -15,7 +16,8 @@ import timber.log.Timber
public class SentryTimberTree(
private val scopes: IScopes,
private val minEventLevel: SentryLevel,
private val minBreadcrumbLevel: SentryLevel
private val minBreadcrumbLevel: SentryLevel,
private val minLogsLevel: SentryLogLevel = SentryLogLevel.INFO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this default value so we don't introduce breaking changes

@stefanosiano stefanosiano changed the base branch from main to feat/logcat-sentry-logs June 13, 2025 14:51
@stefanosiano stefanosiano marked this pull request as ready for review June 13, 2025 14:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 386.38 ms 412.92 ms 26.54 ms
Size 1.58 MiB 2.08 MiB 511.32 KiB

Baseline results on branch: feat/logcat-sentry-logs

Startup times

Revision Plain With Sentry Diff
d035656 399.04 ms 416.73 ms 17.69 ms
771a432 410.52 ms 458.84 ms 48.32 ms

App size

Revision Plain With Sentry Diff
d035656 1.58 MiB 2.08 MiB 511.32 KiB
771a432 1.58 MiB 2.08 MiB 511.32 KiB

Previous results on branch: feat/timber-sentry-logs

Startup times

Revision Plain With Sentry Diff
a3c7c46 399.67 ms 444.53 ms 44.86 ms

App size

Revision Plain With Sentry Diff
a3c7c46 1.58 MiB 2.08 MiB 511.32 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration for Sentry Logs through Timber
1 participant
@stefanosiano