-
-
Notifications
You must be signed in to change notification settings - Fork 455
Create cursor rules file explaining our OpenTelemetry integration #4588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cursor rules file explaining our OpenTelemetry integration #4588
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a7e9275
to
46df387
Compare
0dc4ab2
to
1e939de
Compare
46df387
to
85c39af
Compare
1e939de
to
6fc8adc
Compare
85c39af
to
af58c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't think we want to add the alwaysApply
as we would only apply this selectively when working on OTEL related stuff.
- `sentry-opentelemetry-bootstrap`: Classes that go into the bootstrap classloader when the agent is used. For agentless they are simply used in the applications classloader. | ||
- `sentry-opentelemetry-agentcustomization`: Classes that help wire up Sentry in OpenTelemetry. These land in the agent classloader when the agent is used. For agentless they are simply used in the application classloader. | ||
|
||
## Advantages over using Sentry without OpenTelemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this section relevant for an AI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to give it context to allow making better decisions / provide better insights. We can move this once we have customer facing AI rules files.
@@ -0,0 +1,84 @@ | |||
# Java SDK OpenTelemetry Integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this ruleset?
To give cursor guidance on how to develop in this module? Or to let cursor know how to use this module in a project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly let cursor know but anyone can read it and learn from it.
Co-authored-by: Lukas Bloder <[email protected]>
…r_opentelemetry_integration
#skip-changelog
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps