Skip to content

Create cursor rules file explaining our OpenTelemetry integration #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Aug 1, 2025

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer marked this pull request as ready for review August 1, 2025 08:51
Copy link
Member Author

adinauer commented Aug 1, 2025

@adinauer adinauer requested a review from lcian as a code owner August 1, 2025 08:51
@adinauer adinauer force-pushed the 08-01-create_cursor_rules_file_explaining_our_opentelemetry_integration branch from a7e9275 to 46df387 Compare August 1, 2025 09:06
@adinauer adinauer force-pushed the feat/offline-behaviour-rules-file branch from 0dc4ab2 to 1e939de Compare August 1, 2025 09:06
@adinauer adinauer changed the base branch from feat/offline-behaviour-rules-file to graphite-base/4588 August 1, 2025 09:12
@adinauer adinauer force-pushed the 08-01-create_cursor_rules_file_explaining_our_opentelemetry_integration branch from 46df387 to 85c39af Compare August 1, 2025 09:12
@adinauer adinauer force-pushed the graphite-base/4588 branch from 1e939de to 6fc8adc Compare August 1, 2025 09:13
@graphite-app graphite-app bot changed the base branch from graphite-base/4588 to main August 1, 2025 09:13
@adinauer adinauer force-pushed the 08-01-create_cursor_rules_file_explaining_our_opentelemetry_integration branch from 85c39af to af58c24 Compare August 1, 2025 09:13
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think we want to add the alwaysApply as we would only apply this selectively when working on OTEL related stuff.

- `sentry-opentelemetry-bootstrap`: Classes that go into the bootstrap classloader when the agent is used. For agentless they are simply used in the applications classloader.
- `sentry-opentelemetry-agentcustomization`: Classes that help wire up Sentry in OpenTelemetry. These land in the agent classloader when the agent is used. For agentless they are simply used in the application classloader.

## Advantages over using Sentry without OpenTelemetry
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section relevant for an AI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to give it context to allow making better decisions / provide better insights. We can move this once we have customer facing AI rules files.

@@ -0,0 +1,84 @@
# Java SDK OpenTelemetry Integration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this ruleset?
To give cursor guidance on how to develop in this module? Or to let cursor know how to use this module in a project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly let cursor know but anyone can read it and learn from it.

@adinauer adinauer enabled auto-merge (squash) August 13, 2025 11:24
@adinauer adinauer merged commit c626414 into main Aug 13, 2025
35 of 37 checks passed
@adinauer adinauer deleted the 08-01-create_cursor_rules_file_explaining_our_opentelemetry_integration branch August 13, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants