feat(alerts): Add support for log type alert #93043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93043 +/- ##
========================================
Coverage 82.87% 82.87%
========================================
Files 10295 10295
Lines 590832 591000 +168
Branches 22980 22980
========================================
+ Hits 489647 489802 +155
- Misses 99751 99764 +13
Partials 1434 1434 |
shruthilayaj
commented
Jun 6, 2025
|
|
||
| assert ( | ||
| createSubscriptionRequest.time_series_request.meta.trace_item_type | ||
| == TraceItemType.TRACE_ITEM_TYPE_LOG |
There was a problem hiding this comment.
making sure snuba subscription is created with trace item type log
shruthilayaj
commented
Jun 6, 2025
|
|
||
| assert ( | ||
| createSubscriptionRequest.time_series_request.meta.trace_item_type | ||
| == TraceItemType.TRACE_ITEM_TYPE_SPAN |
There was a problem hiding this comment.
making sure snuba subscription is created with trace item type span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spans and logs to valid event types for performance alerts.
Update entity subscription to use the correct trace item type in
SearchResolver