Skip to content

feat(insights): open http response rate chart in comparison view #93050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Jun 6, 2025

When you click the open to explore button in the http response code chart, we will now open it in the compare query mode. This is because http_response_rate is not a function that will be exposed in explore, so this is a comparable way to get similar data in explore.

To support this, i also had to update generateExploreCompareRoute to accept an array of queries to compare

I.e when you click this
image

It shows up as this
image

@DominikB2014 DominikB2014 requested review from a team as code owners June 6, 2025 18:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93050      +/-   ##
==========================================
- Coverage   82.87%   82.87%   -0.01%     
==========================================
  Files       10295    10295              
  Lines      590815   590814       -1     
  Branches    22980    22980              
==========================================
- Hits       489629   489628       -1     
  Misses      99752    99752              
  Partials     1434     1434              

@DominikB2014 DominikB2014 enabled auto-merge (squash) June 9, 2025 14:19
@DominikB2014 DominikB2014 merged commit a268a2c into master Jun 9, 2025
43 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-592-open-http-response-rate-chart-in-comparison-view branch June 9, 2025 14:30
DominikB2014 added a commit that referenced this pull request Jun 10, 2025
…iew (#93132)

1. Exact same as #93050
except for http response rate summary chart (instead of landing page)
2. All updated the landing summary chart the pass in the
`stringifiedSearch` into the queries, missed this in the previous PR
billyvg pushed a commit that referenced this pull request Jun 10, 2025
…iew (#93132)

1. Exact same as #93050
except for http response rate summary chart (instead of landing page)
2. All updated the landing summary chart the pass in the
`stringifiedSearch` into the queries, missed this in the previous PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants