Skip to content

feat(uptime)Create Advanced Config Section #93064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Jun 6, 2025

Some of what was displayed for uptime monitor config was not needed for every user IMO. So it is move to a advanced config section, which is collapsed by default

Some of what was displayed for uptime monitor config was not needed for every user IMO. So it is move to a advanced config section, which is collapsed by default
@smeubank smeubank requested a review from a team as a code owner June 6, 2025 20:41
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@smeubank smeubank changed the title Create Advanced Config Section feat(uptime)Create Advanced Config Section Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
10515 4 10511 9
View the top 3 failed test(s) by shortest run time
Uptime Alert Form can edit an existing rule
Stack Traces | 0.283s run time
TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "Interval"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "":
  ...

  Name "Save Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  code:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at input (.../rules/uptime/uptimeAlertForm.spec.tsx:34:40)
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:187:39)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)
Uptime Alert Form renders existing rule
Stack Traces | 0.307s run time
TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "Body"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "":
  ...

  Name "Save Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  code:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at input (.../rules/uptime/uptimeAlertForm.spec.tsx:34:40)
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:115:12)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
Uptime Alert Form can create a new rule
Stack Traces | 0.453s run time
TestingLibraryElementError: Unable to find an accessible element with the role "slider" and name "Timeout"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "Create Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:47:49)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant