-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(issues): Implement suspect flag heuristics for feature flags aggregated inside issue details #93076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
2a32413
to
6a7527f
Compare
distribution: { | ||
baseline: Record<string, number>; | ||
outliers: Record<string, number>; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to match #92801
a388e29
to
3d900bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93076 +/- ##
=======================================
Coverage 87.82% 87.83%
=======================================
Files 10284 10284
Lines 590331 590285 -46
Branches 22950 22941 -9
=======================================
- Hits 518468 518457 -11
+ Misses 71416 71381 -35
Partials 447 447 |
I approve 👍 |
This isn't a final UI for everything, still behind it's own FF for employees right now only.
If this set of heuristics turns out to be decent for a range of issues, then we'll have to iterate and move a bunch of logic into the backend directly. Right now it's fun and easy to experiment in the frontend, and render data related to what's used in the heuristics (ie: we use distribution, so render that too).
I'm happier with the results of this algorithm in this iteration. What i've found by spot-checking a bunch of issues is that the flags which are surfaced seem related to the issue i'm looking at. more cross-cutting issues are showing more generic flags, like the
trace-view-v1
flag in the example. But I'm happy because it's trace related and the problem happened on the trace page.What the new heuristic is focused on a few things types of flags:
foo=true
but had some single-digit cases wherefoo=false
. These are tricky!