ref(replay): delete seer data on replay deletes #97279
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97279 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 8559 8559
Lines 376667 376755 +88
Branches 24492 24491 -1
=======================================
+ Hits 303660 303731 +71
- Misses 72637 72654 +17
Partials 370 370 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -43,32 +47,17 @@ | |||
| ), | |||
| ), | |||
| ) | |||
| def delete_recording_segments(project_id: int, replay_id: str, **kwargs: Any) -> None: | |||
| def delete_replay( | |||
There was a problem hiding this comment.
Renamed this to match its purpose of deleting a single replay - archive event, del recording segments, and request seer. Maybe this can later be replaced by this task I removed recently, since they seem to be very similar?
| """Asynchronously delete a replay.""" | ||
| metrics.incr("replays.delete_recording_segments", amount=1, tags={"status": "started"}) | ||
| metrics.incr("replays.delete_replay", amount=1, tags={"status": "started"}) |
There was a problem hiding this comment.
Not sure if we're using this metric anywhere, I can restore if needed
|
The shared util was removed because now we want to migrate to the existing |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Part of [REPLAY-538: Delete async summaries when replay is deleted](https://linear.app/getsentry/issue/REPLAY-538/delete-async-summaries-when-replay-is-deleted). Sends a seer request to delete summaries when a replay is deleted from bulk delete or replay details endpoints. Seer deletes were not added to the delete_replays script. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Part of REPLAY-538: Delete async summaries when replay is deleted. Sends a seer request to delete summaries when a replay is deleted from bulk delete or replay details endpoints. Seer deletes were not added to the delete_replays script.
Seer endpoint: https://github.com/getsentry/seer/pull/3101