feat(onboarding): Add dart onboarding and revamp flutter logs onboarding #97432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dart onboarding page to product - Add logs to verify section for flutter onboarding - Add logs and tracing production selection to dart onboarding
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
+53
to
+55
| Sentry.logger.info("User triggered test error", { | ||
| 'action': SentryLogAttribute.string('test_error'), | ||
| });` |
There was a problem hiding this comment.
Potential bug: The Dart onboarding guide generates code using `SentryLogAttribute` but falls back to an incompatible SDK version (`7.8.0`), causing compilation errors when the package registry is down.
- Description: When the 'logs' feature is selected in the Dart onboarding documentation, the generated code uses
SentryLogAttribute. However, if the Sentry package registry is unavailable, the configuration falls back to usingsentry.dartversion7.8.0. This version predates the introduction ofSentryLogAttribute(added in v9.0.0), which will cause a compilation error for the user. This breaks the onboarding flow under network or API failure conditions, preventing successful SDK integration. - Suggested fix: Update the fallback version for the
sentry.dartpackage to at least9.0.0to ensure compatibility with the logging features. Alternatively, the code generation for logging should be conditional on the resolved SDK version supporting the feature.
severity: 0.75, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
yoo good work seer! you right!
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/getsentry/issue/LOGS-289/add-verify-steps-to-flutter-onboarding
I noticed dart doesn't show up in the in-product onboarding, so added it here. Also then updated everything for logs, and cleaned up some of the code/snippets.