fix: Use trimmed package name for flamegraph #97436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasBa
approved these changes
Aug 8, 2025
noahsmartin
force-pushed
the
fixFramePackageName
branch
from
f36bf06 to
3059acd
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
The aggregate flamegraph on the transaction summary page is getting the flamegraph data from vroom which is already applying package name trimming when it aggregates the flamegraphs. However the individual profile view did not do this and showed the whole package name, which wasn't a good UX. Before: <img width="1980" height="374" alt="Screenshot 2025-08-07 at 5 08 46 PM" src="https://github.com/user-attachments/assets/0ebe228f-edf4-4c49-9217-d3c6d6cabfe4" /> After: <img width="1228" height="386" alt="Screenshot 2025-08-07 at 5 08 23 PM" src="https://github.com/user-attachments/assets/58e4e127-ecfb-4edd-9731-63f2563bd85e" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregate flamegraph on the transaction summary page is getting the flamegraph data from vroom which is already applying package name trimming when it aggregates the flamegraphs. However the individual profile view did not do this and showed the whole package name, which wasn't a good UX.
Before:
After:
