Skip to content

chore(rpc): follow the logging pattern we use in other places #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(rpc): follow the logging pattern we use in other places #7419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5778eda
follow the logging pattern we use in other places
davidtsuk Sep 18, 2025
9510081
fix
davidtsuk Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions snuba/web/rpc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
RoutingStrategySelector,
)

logger = logging.getLogger("snuba.rpc")

_TIME_PERIOD_HOURS_BUCKETS = [
1,
24,
Expand Down Expand Up @@ -316,7 +318,7 @@ def _before_execute(self, in_msg: Tin) -> None:
request_id = in_msg.meta.request_id

# Log RPC request start
logging.info(
logger.info(
f"RPC request started - endpoint: {self.__class__.__name__}, request_id: {request_id}"
)

Expand Down Expand Up @@ -380,7 +382,7 @@ def _after_execute(self, in_msg: Tin, out_msg: Tout, error: Exception | None) ->
request_id = in_msg.meta.request_id

status = "error" if error is not None else "success"
logging.info(
logger.info(
f"RPC request finished - endpoint: {self.__class__.__name__}, request_id: {request_id}, status: {status}"
)
flush_logs = state.get_float_config("rpc_logging_flush_logs", 0)
Expand Down
Loading