Skip to content

fix(TraceItemTable): use islice to slice results rather than array slicing #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(TraceItemTable): use islice to slice results rather than array slicing #7422

wants to merge 3 commits into from

Conversation

volokluev
Copy link
Member

an array slice makes a copy of the references in the table, an islice just makes a pointer so we save some memory

@volokluev volokluev requested review from a team as code owners September 23, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phacops phacops phacops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volokluev @phacops