Skip to content

ci/package_checks: Run package version checks against commits #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Jun 25, 2025

Summary

Update the PackageBumped check to check each commit individually, and check the untracked/modified files separately.

Resolves #5900

Test Plan

Ran locally against #5881. It now finds:

WRN packages/d/dotnet/package.yml:1: Package release is not incremented by 1 (ref: dc4f4a2d97b65beafde2016fe572f983318e3bfa)

Previously, it found:

WRN packages/d/dotnet-8/package.yml:1: Package release is not 1
ERR packages/d/dotnet-8/pspec_x86_64.xml:1: Package release is not 1
WRN packages/d/dotnet/package.yml:1: Package release is not incremented by 1
ERR packages/d/dotnet/pspec_x86_64.xml:1: Package release is not incremented by 1

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

**Summary**

Update the `PackageBumped` check to check each commit individually, and check the untracked/modified files separately.
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger merged commit b231c1c into main Jun 25, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Solus Jun 25, 2025
@EbonJaeger EbonJaeger deleted the package-checks-check-commits branch June 25, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CI: Package lint job cannot handle more than one commit to a single package
2 participants