Skip to content

Automatic sound switching and Support audio devices with more than 2 channels #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

probonopd
Copy link

@probonopd probonopd commented Jul 16, 2025

Backport

Summary by Sourcery

Backport sysctl configuration changes to enable automatic audio device switching and support for multi-channel USB audio.

Enhancements:

  • Enable automatic audio device switching with hw.snd.default_auto=2
  • Support USB audio devices with more than two channels by setting hw.usb.uaudio.default_channels=6

@probonopd probonopd requested review from a team as code owners July 16, 2025 00:15
@ghostbsd-bot
Copy link

Can one of the admins verify this patch?

Copy link

sourcery-ai bot commented Jul 16, 2025

Reviewer's Guide

Backports audio-related sysctl settings from PRs #369 and #370 by updating sysctl.conf to enable automatic audio device switching and increase USB audio channel support.

Class diagram for updated sysctl.conf audio settings

classDiagram
    class sysctl.conf {
        +kern.ipc.shm_allow_removed=1
        +kern.sched.preempt_thresh=224
        +kern.geom.part.mbr.enforce_chs=0
        +hw.snd.default_auto=2
        +hw.usb.uaudio.default_channels=6
    }
Loading

File-Level Changes

Change Details Files
Introduce sysctl options for improved audio handling
  • Enable automatic switching between audio devices (e.g., HDMI to USB)
  • Allow USB audio devices to use up to 6 channels
sbin/sysctl/sysctl.conf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Management Jul 16, 2025
@ericbsd
Copy link
Member

ericbsd commented Jul 16, 2025

test this

@ericbsd
Copy link
Member

ericbsd commented Jul 16, 2025

I let Jenkins run, and I will merge when it is completed.

@ericbsd ericbsd merged commit 54b45ba into ghostbsd:releng/14.3 Jul 16, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Management Jul 16, 2025
@ericbsd ericbsd changed the title Backport #369, #370 Automatic sound switching and Support audio devices with more than 2 channels Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants