refactor(internal/bytesconv): replace rand usage with crypto/rand and rand.New #4259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors random usage to follow current best practices in Go 1.20+:
Replaced usage of
math/rand.Read
, which is deprecated, withcrypto/rand.Read
.As per the deprecation notice,
crypto/rand.Read
is more appropriate for almost all use cases.Replaced
rand.NewSource(time.Now().UnixNano())
withrand.New(rand.NewSource(time.Now().UnixNano()))
.rand.NewSource
returns a bare Source which lacks convenience methods likeIntn
,Float64
, etc.Wrapping it with
rand.New
provides a complete and idiomatic*rand.Rand
object.