Fix VPC manage vtep assumption #771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
approved these changes
Aug 11, 2025
The order of the returned vectors was inverted according to the condition. Either we invert the condtion or we swap the outputs. Went for the latter and convert the output vector to iterator. Signed-off-by: Fredi Raspall <[email protected]>
Signed-off-by: Fredi Raspall <[email protected]>
The dataplane may receive configurations that do not include any VPC. In that case (i.e. underlay-only configs) we can't assume that the vtep configuration is there as it is not needed. So, the vpc manager should only assume that a vtep config is present if there are VPCs (vrfs aside from the default). The original code worked fine because the default vrf was excepted by the vpc manager: if there were no vrfs other than the default, we were not checking for the existence of a vtep, and if there were, the validation of the configuration ensured that a vtep was present. A guard for this was removed in 3301da3 when the vpc manager started to create interfaces for the default vrf, which broke the original assumption. Restoring the guard that excepted the default vrf is no longer suffices to fix the problem since we need to configure interfaces for the default vrf. So, split the method to iterate over non-default vrfs and then deal with the interfaces for the default vrf. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
force-pushed
the
pr/fredi/fix_vpc_mgr
branch
from
b47b048 to
ce90203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very fond of this fix, but it should work.
Please refer to the commit for the explanation of the issues.