fix(versions): log release versions when config is missing #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frostman
reviewed
Jul 8, 2025
pau-hedgehog
force-pushed
the
pau/hhfab_versions
branch
2 times, most recently
from
8a003bb to
3785e41
Compare
|
I'm removing the |
pau-hedgehog
force-pushed
the
pau/hhfab_versions
branch
from
30a65d8 to
4a2bd42
Compare
When no fab.yaml is found, the versions command shows the release versions instead of an error If there are overrides in fab.yaml, they are shown Signed-off-by: Pau Capdevila <[email protected]>
hhfab versions --live Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
pau-hedgehog
force-pushed
the
pau/hhfab_versions
branch
from
4a2bd42 to
fc41208
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the versions command to:
- Fallback to printing built-in release versions when no
fab.yamlis found - Introduce a
--liveflag to fetch versions from a running Fabricator in-cluster - Update CI workflows to invoke
bin/hhfab versionsand remove the oldVersionsincmdconfig.go
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/hhfab/cmdversions.go | New command implementation handling missing config and live fetch |
| pkg/hhfab/cmdconfig.go | Remove deprecated Versions function |
| cmd/hhfab/main.go | Add --live flag to the versions command |
| .github/workflows/ci.yaml | Invoke bin/hhfab versions in multiple CI steps |
Comments suppressed due to low confidence (2)
pkg/hhfab/cmdversions.go:96
- Add unit tests for formatVersions and compareVersionMaps to verify correct YAML output in both override and no-override scenarios.
func formatVersions(releaseVersions, overriddenVersions fabapi.Versions) (string, error) {
pkg/hhfab/cmdversions.go:21
- [nitpick] Add a Go doc comment for the exported Versions function explaining its parameters and behavior (missing config vs live cluster).
func Versions(ctx context.Context, workDir, cacheDir string, hMode HydrateMode, live bool) error {
| overriddenMap, err := convertToMap(overriddenVersions) | ||
| if err != nil { | ||
| slog.Warn("Failed to convert overridden versions", "error", err) | ||
| data, _ := kyaml.Marshal(releaseVersions) |
There was a problem hiding this comment.
Avoid ignoring the error from kyaml.Marshal here; handle or log it so that serialization failures in the fallback path are not silently dropped.
Suggested change
| data, _ := kyaml.Marshal(releaseVersions) | |
| data, marshalErr := kyaml.Marshal(releaseVersions) | |
| if marshalErr != nil { | |
| slog.Warn("Failed to marshal release versions", "error", marshalErr) | |
| return "", fmt.Errorf("marshalling release versions: %w", marshalErr) | |
| } |
Copilot uses AI. Check for mistakes.
Comment on lines
+52
to
+64
| freshFab := fabapi.Fabricator{} | ||
| if err := freshFab.CalculateVersions(fab.Versions); err != nil { | ||
| return fmt.Errorf("calculating default versions: %w", err) | ||
| } | ||
|
|
||
| versionsData, err := formatVersions(freshFab.Status.Versions, cfg.Fab.Status.Versions) | ||
| if err != nil { | ||
| return fmt.Errorf("formatting versions: %w", err) | ||
| } | ||
|
|
||
| fmt.Println(versionsData) | ||
|
|
||
| return nil |
There was a problem hiding this comment.
[nitpick] There are multiple duplicated blocks that call CalculateVersions and print results; consider extracting common code into a helper to reduce duplication.
Suggested change
| freshFab := fabapi.Fabricator{} | |
| if err := freshFab.CalculateVersions(fab.Versions); err != nil { | |
| return fmt.Errorf("calculating default versions: %w", err) | |
| } | |
| versionsData, err := formatVersions(freshFab.Status.Versions, cfg.Fab.Status.Versions) | |
| if err != nil { | |
| return fmt.Errorf("formatting versions: %w", err) | |
| } | |
| fmt.Println(versionsData) | |
| return nil | |
| return processVersions(fab.Versions, cfg.Fab.Status.Versions, false) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no fab.yaml is found, the versions command shows the release versions instead of an error:
VS:
If there are overrides in fab.yaml or in the API object, they are shown: