Produce separate SARIF file for quality-queries alerts

pr-checks/checks/quality-queries.yml

@@ -11,16 +11,22 @@ steps:
     with:
       output: "${{ runner.temp }}/results"
       upload-database: false
-  - name: Upload SARIF
+  - name: Upload security SARIF
     uses: actions/upload-artifact@v4
     with:
       name: config-export-${{ matrix.os }}-${{ matrix.version }}.sarif.json
       path: "${{ runner.temp }}/results/javascript.sarif"
       retention-days: 7
+  - name: Upload quality SARIF
+    uses: actions/upload-artifact@v4
+    with:
+      name: config-export-${{ matrix.os }}-${{ matrix.version }}.quality.sarif.json
+      path: "${{ runner.temp }}/results/javascript.quality.sarif"
+      retention-days: 7
   - name: Check config properties appear in SARIF
     uses: actions/github-script@v7
     env:
-      SARIF_PATH: "${{ runner.temp }}/results/javascript.sarif"
+      SARIF_PATH: "${{ runner.temp }}/results/javascript.quality.sarif"
     with:
       script: |
         const fs = require('fs');

src/analyze-action.ts

@@ -329,6 +329,18 @@ async function run() {
         logger,
       );
       core.setOutput("sarif-id", uploadResult.sarifID);
+
+      if (config.augmentationProperties.qualityQueriesInput !== undefined) {
+        const qualityUploadResult = await uploadLib.uploadFiles(
+          outputDir,
+          actionsUtil.getRequiredInput("checkout_path"),
+          actionsUtil.getOptionalInput("category"),
+          features,
+          logger,
+          uploadLib.CodeQualityTarget,
+        );
+        core.setOutput("quality-sarif-id", qualityUploadResult.sarifID);
+      }
     } else {
       logger.info("Not uploading results");
     }

src/analyze.ts

@@ -561,6 +561,14 @@ extensions:
   return diffRangeDir;
 }
 
+function resolveQuerySuiteAlias(language: Language, query: string): string {
+  if (query === "code-quality") {
+    return `${language}-code-quality.qls`;
+  }
+
+  return query;
+}
+
 // Runs queries and creates sarif files in the given folder
 export async function runQueries(
   sarifFolder: string,
@@ -618,6 +626,24 @@ export async function runQueries(
         sarifFile,
         config.debugMode,
       );
+      if (config.augmentationProperties.qualityQueriesInput !== undefined) {
+        logger.info(`Interpreting quality results for ${language}`);
+        const qualitySarifFile = path.join(
+          sarifFolder,
+          `${language}.quality.sarif`,
+        );
+        const qualityAnalysisSummary = await runInterpretResults(
+          language,
+          config.augmentationProperties.qualityQueriesInput.map((i) =>
+            resolveQuerySuiteAlias(language, i.uses),
+          ),
+          qualitySarifFile,
+          config.debugMode,
+        );
+
+        // TODO: move
+        logger.info(qualityAnalysisSummary);
+      }
       const endTimeInterpretResults = new Date();
       statusReport[`interpret_results_${language}_duration_ms`] =
         endTimeInterpretResults.getTime() - startTimeInterpretResults.getTime();