-
Notifications
You must be signed in to change notification settings - Fork 88
Add ability to set storeconfig_backends #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0fdfde6
add functionality to set storeconfigs-backend
ngrundy baacd69
tweak storeconfigs_backend_spec
ngrundy 93b6fed
add expected storeconfigs_backend to defaults in cli_spec
ngrundy 3be5d63
fix spelling error in cfg file
ngrundy 883c429
Merge branch 'master' into storeconfigs-backend
jhongturney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# frozen_string_literal: true | ||
|
||
# Set storeconfigs (integration with PuppetDB for collected resources) | ||
# @param parser [OptionParser object] The OptionParser argument | ||
# @param options [Hash] Options hash being constructed; this is modified in this method. | ||
OctocatalogDiff::Cli::Options::Option.newoption(:storeconfigs) do | ||
has_weight 220 | ||
|
||
def parse(parser, options) | ||
parser.on('--storeconfigs-backend TERMINUS', 'Set the terminus used for storeconfigs') do |x| | ||
options[:storeconfigs_backend] = x | ||
end | ||
end | ||
end |
12 changes: 12 additions & 0 deletions
12
spec/octocatalog-diff/tests/cli/options/storeconfigs_backend_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# frozen_string_literal: true | ||
|
||
require_relative '../options_helper' | ||
|
||
describe OctocatalogDiff::Cli::Options do | ||
describe '#opt_storeconfigs_backend' do | ||
it 'should accept all valid arguments' do | ||
result = run_optparse(['--storeconfigs-backend', 'puppetdb']) | ||
expect(result[:storeconfigs_backend]).to eq('puppetdb') | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.