Open the possibility to cleanly overwrite the dataset read and open functions #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charalamm I'll take a look at this, but supporting retries would be a very welcome feature, so if that's the only use case for this refactor (it's the only one I can think of), it might be better to work towards a PR for retries? I just noticed your comments on #18, so I'll take a look at that too. |
|
@gjoseph92 thanks for looking into this. Sure I would love to work on a PR that is about retries. |
|
FYI @charalamm, I have started on a PR adding retries: #232. Please have a look! (It's not done yet.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to allow the user to add retries on user-specified errors