gitignore some documentation-related outputs #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivucica
approved these changes
Jul 12, 2025
There was a problem hiding this comment.
Looks like none of these are checked in now. LGTM.
Before merge, I'd consider updating the commit text (git commit --amend) to document why the changes are needed, where the files come from during the build, etc. Future readers might be as interested as I am right now. Or do it in the .gitignore itself.
Optional, however, as this is a minor request.
| @@ -10,6 +10,7 @@ Tests/base/*/GNUmakefile | |||
| *.sum | |||
| Tools/BaseTools/dependencies | |||
| Source/gnustep-base.pc | |||
| Tools/Resources/autogsdoc/default-styles.css | |||
There was a problem hiding this comment.
Seems to be copied from one level up, LGTM
| @@ -111,3 +112,7 @@ Documentation/manual/manual.* | |||
| **/dependencies | |||
| Source/Base.gsdoc | |||
| Source/BaseAdditions.gsdoc | |||
| Documentation/manual/gs-base.info | |||
| Documentation/manual/gs-base | |||
| Documentation/gs-standards | |||
There was a problem hiding this comment.
These three seem to also come from elsewhere.
Could you update at least the commit text to document where they came from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes
.gitignore.