"Enter" icon in default button only for certain NSInterfaceStyles #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show "Enter" icon in default button only if NSInterfaceStyle is NSNextStepInterfaceStyle or GSWindowMakerInterfaceStyle. This looks alien in other interface styles.
fredkiefer
approved these changes
Jul 13, 2025
Source/GSHelpManagerPanel.m
Outdated
| @@ -101,8 +101,13 @@ - (id)init | |||
| [button setTitle: NSLocalizedString(@"OK", @"")]; | |||
| [button setKeyEquivalent: @"\r"]; | |||
| [button setImagePosition: NSImageRight]; | |||
| [button setImage: [NSImage imageNamed: @"common_ret"]]; | |||
| [button setAlternateImage: [NSImage imageNamed: @"common_retH"]]; | |||
| NSInterfaceStyle interfaceStyle = NSInterfaceStyleForKey(@"NSInterfaceStyle", nil); | |||
There was a problem hiding this comment.
The indentation here looks wrong
|
Thanks @fredkiefer for reviewing this. I am not familiar with the GNUstep mailing lists but if you'd like to take it there feel free to. In NSMacintoshInterfaceStyle and themes like Rik, what is conveyed by the "enter" icon should be conveyed by the blue pulsing color and/or blue highlight glow around the button, shouldn't it? Similarly on Windows, I have never seen this icon in Windows native applications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show "Enter" icon in default button only if
NSInterfaceStyleisNSNextStepInterfaceStyleorGSWindowMakerInterfaceStyle.That icon looks alien in other interface styles such as
NSMacintoshInterfaceStyle:Reference: