Skip to content

Fix footnote jump behavior on the issue page. (#34621) #34669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Jun 9, 2025

Backport #34621 by @charles7668

Close #34511
Close #34590

Add comment ID to the footnote item's id attribute to ensure uniqueness.

Close go-gitea#34511 
Close go-gitea#34590 

Add comment ID to the footnote item's id attribute to ensure uniqueness.

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added modifies/frontend modifies/go Pull requests that update Go code type/bug labels Jun 9, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jun 9, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 9, 2025
@GiteaBot GiteaBot requested review from lunny and wxiaoguang June 9, 2025 17:44
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 9, 2025
@lunny lunny enabled auto-merge (squash) June 9, 2025 20:31
@lunny lunny merged commit b947bc4 into go-gitea:release/v1.24 Jun 9, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants