Skip to content

Refine mail templates #35150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Refine mail templates #35150

wants to merge 13 commits into from

Conversation

NorthRealm
Copy link
Contributor

@NorthRealm NorthRealm commented Jul 23, 2025 •
edited
Loading

  • Moved mail templates to new directories.
  • Added new devtest ymls.
  • Embedded styles as much as possible.
  • Added new translation keys for actions email.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 23, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 23, 2025
@lunny lunny added this to the 1.25.0 milestone Jul 23, 2025
delvh
delvh reviewed Jul 24, 2025
View reviewed changes
@NorthRealm NorthRealm force-pushed the patch-mail-templates-1 branch from e1d2ca4 to 3ff5727 Compare July 24, 2025 12:04
@NorthRealm NorthRealm requested a review from delvh July 25, 2025 06:26
wxiaoguang
wxiaoguang requested changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

templates/mail/footer_gitea.tmpl is not right

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 27, 2025
@NorthRealm NorthRealm requested a review from wxiaoguang July 27, 2025 09:49
wxiaoguang
wxiaoguang reviewed Jul 27, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not right, footer_view_on_gitea.tmpl is not right either. The HTML layouts are wrong, and it is fragile by passing all variables "." to sub-templates (In history many 500 errors were caused by that).

Recently I don't have time to do further reviews for PRs, other maintainers could help to review and improve, and feel free to dismiss the "change request" if the concerns have been addressed.

delvh
delvh reviewed Jul 27, 2025
View reviewed changes
templates/mail/footer_gitea.tmpl
<!DOCTYPE html>
<html>
<body>
<p>© <a href="{{AppUrl}}">{{AppName}}</a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, shouldn't this be only the <p>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the screenshot would tell.

It doesn't make sense to render a "sub template" as a whole page.

@NorthRealm
Copy link
Contributor Author

@wxiaoguang I don't understand why dict is not working as intended. I'm giving up. 😅

@NorthRealm NorthRealm closed this Jul 27, 2025
@NorthRealm NorthRealm deleted the patch-mail-templates-1 branch July 27, 2025 12:32
@wxiaoguang
Copy link
Contributor

I think you can revert "sub template" related changes, only make clear changes you need.

@NorthRealm NorthRealm restored the patch-mail-templates-1 branch July 27, 2025 12:54
@GiteaBot GiteaBot removed this from the 1.25.0 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

@delvh delvh delvh left review comments

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NorthRealm @wxiaoguang @delvh @lunny @GiteaBot