Skip to content

Conversation

p0dalirius
Copy link
Contributor

@p0dalirius p0dalirius commented Jun 29, 2025

Hi,

I have added a new structure for the LDAP_SERVER_SD_FLAGS_OID control structure that allows to query security descriptors on Windows. Otherwise, as this was brought to me by a colleague, they are not returned in the results of the LDAP query (only empty values).

https://stackoverflow.com/questions/40771503/selecting-the-ad-ntsecuritydescriptor-attribute-as-a-non-admin/40773088#40773088

Source: https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/3888c2b7-35b9-45b7-afeb-b772aa932dd0

In the future, wouldn't that be nice to have a controls/ submodule containing one file per control structure as well as a global file containing all the OIDs? This would make the codebase more readable in my opinion. What do you think @cpuschma?
If you agree I volunteer to do this for the Microsoft Controls :)

Best regards,

p0dalirius added a commit to TheManticoreProject/Manticore that referenced this pull request Jun 29, 2025
@cpuschma cpuschma self-assigned this Jun 29, 2025
@cpuschma cpuschma merged commit 06d7bd9 into go-ldap:master Jun 29, 2025
4 checks passed
@cpuschma
Copy link
Member

Thank you for your PR, @p0dalirius. While moving the controls to their own module would certainly clean up the codebase, it would also break backwards compatibility. As with v3, we would have to introduce a transition period and maintain the controls in both folders. I'm open for solutions to this!

@johnweldon
Copy link
Member

I think we could move the controls into the sub module and then just put type aliases in the top level module

@p0dalirius p0dalirius deleted the patch-1 branch June 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants