COLR table #196
Open
COLR table #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whereswaldon
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Thanks for putting this together @benoitkugler! I think it looks reasonable, though I lack your deep expertise in the internals of opentype. My only real question is whether we need so many implementations of binary search? Not a huge deal though. Great work!
I'm not a big fan of the sort.Search API, but I guess it is OK as a temporary solution until we can use go 1.21 and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards support for the COLR/CPAL tables.
We expose a new
GlyphColortype returned byFace.GlyphData. With this API, a renderer may now load the layers defining a colored glyph and combine them. This could be implemented for instance in go-text/render.This PR is probably not enough to support variable fonts, but starting with non variable ones should already be pretty nice.