-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add pnpm and changesets to manage repository #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
What's the motivation behind uploading and downloading the JS runtime instead of just building it? I can understand the motivation for v8, since it lives outside of the repository. However, I'm not sure I understand re: the runtime. Is there potential for race conditions here if multiple builds are kicked off and replace the runtime artifacts? |
It's possible to move the builds for the jsb runtime to a custom action and run it in every OS build. But it reuqires to setup node/pnpm every time. Furthermore, we need to move down to By moving it to a separate workflow_call we reduce the build time but we have the upload/download stuff. We can create a custom action instead I don't have a preference |
Just a comment from personal experience ... pnpm is not significantly better than npm, especially not for a project with so few npm dependencies. And the latest versions of npm have workspace support out of the box. Unless there is an obvious use case for pnpm that npm can't satisfy, I'd just suggest sticking with npm which any Typescript developer is guaranteed to already have installed. |
Personally I like |
Mmm. I tend to avoid these conversations 😅 It's sort of like asking "why use GodotJS when there's already GDScript?" Personally, I use pnpm for my own projects, so it's what I would have picked. But I'm not tied to it. That said, I don't think it's accurate to say developers already have npm and don't have pnpm. Package managers themselves have versions, each project will (or at least should) be using a specific version. So a package manager is very likely going to have to be downloaded regardless. Since corepack is bundled in modern Node, it's really no hassle either way. |
Surely npm is still installed as part of node? You'd have to go to extra lengths to not have it. |
Well it turns out I didn't even know what corepack did :) But it also turns out it's being removed from the distribution in node 25+. https://www.reddit.com/r/node/comments/1jk3vhn/what_are_the_ramifications_of_corepack_being/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to get used to the new workflow. But I think we should merge this and tweak if we run into problem.
closes #95
pnpm
to manage the creation of all.ts
files insidescripts
folder withpnpm build
scripts/out
should be build in pipeline or locally to make sure everything is up to datejsb_version.h
automaticallyCONTRIBUTING.md