Update workflow to handle panic in pipeline #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gger, pubsub/google, etc.) (gofr-dev#2109)
|
Handle panic as in?? can you update the description what we are actually trying to do here? |
Done. |
Umang01-hash
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we previously added retry, the retry was also executed on panics, which is not ideal so there was a need to update our workflow. Even though these tests were panicking and exiting locally, the workflow job did not use to fail before.
Hence this has been fixed here. This PR should only be merged after Fix config Overloading & its tests #2240 & Fixed websocket implementation & tests #2239