Fix Dataset.get_data to only return requested fields (Issue #280) #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue goldmansachs#280: when callers passed fields=[...], Dataset.get_data previously returned the full dataset schema with non-selected columns filled with NaN. Now requested fields are sanitized & mapped to snake_case and the returned DataFrame is filtered to only those columns when present. covered by: Jakiur Rahman.dco
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #280: Dataset.get_data(fields=[...]) returned all dataset columns with non-selected ones filled with NaN.
Changes:
and filters the DataFrame returned by the provider to only the requested columns that exist.
fieldsis provided users get onlythe selected columns (no NaN columns).
DummyProvider to validate the behavior without network calls.
Notes & rationale:
unexpectedly dropping all data (non-breaking default). Maintainers may request a stricter behavior; happy to adjust.
covered by: Jakiur Rahman.dco