Skip to content

Make project_id an optional input #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

DefCon-007
Copy link
Contributor

The code and readme specify the project_id as optional, but it is marked as required in the action.yml file. Marking it as optional

@DefCon-007 DefCon-007 requested a review from a team as a code owner July 2, 2025 09:31
@DefCon-007 DefCon-007 requested review from sethvargo and verbanicm July 2, 2025 09:31
Copy link

google-cla bot commented Jul 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

The code and readme specify the `project_id` as optional, but it is marked as required in the `action.yml` file. Marking it as optional 

Signed-off-by: Ayush Goyal <[email protected]>
@sethvargo sethvargo merged commit 60d3247 into google-github-actions:main Jul 21, 2025
11 checks passed
sethvargo added a commit that referenced this pull request Jul 21, 2025
Now that
#383 is
merged, we can make this optional.
google-github-actions-bot added a commit that referenced this pull request Jul 21, 2025
## What's Changed
* Make `project_id` an optional input by @DefCon-007 in
#383
* Remove optional project_id field by @sethvargo in
#387

## New Contributors
* @DefCon-007 made their first contribution in
#383

**Full Changelog**:
v2.1.6...v2.1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants