Fix: Handle Pydantic v2 ValidationError in AgentLoader #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AgentLoader previously attempted to access `e.msg` on exceptions encountered during agent loading. This caused a crash when the exception was a `pydantic_core._pydantic_core.ValidationError` from Pydantic v2+, as this error type does not have a `msg` attribute. This commit modifies the exception handling in `AgentLoader`'s `_load_from_module_or_package` and `_load_from_submodule` methods to use `str(e)` instead of `e.msg`. This ensures that the error message is correctly retrieved for all exception types, including Pydantic v2 `ValidationError`. A new test case has been added to specifically verify this scenario by simulating a Pydantic v2 style error during agent loading. Existing tests for other error types (SyntaxError, NameError) within agent code have been updated to reflect the new `RuntimeError` wrapping behavior of the AgentLoader. Fixes #1227
|
Hi @hangfei it look good to me and please make sure run test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AgentLoader previously attempted to access
e.msgon exceptions encountered during agent loading. This caused a crash when the exception was apydantic_core._pydantic_core.ValidationErrorfrom Pydantic v2+, as this error type does not have amsgattribute.This commit modifies the exception handling in
AgentLoader's_load_from_module_or_packageand_load_from_submodulemethods to usestr(e)instead ofe.msg. This ensures that the error message is correctly retrieved for all exception types, including Pydantic v2ValidationError.A new test case has been added to specifically verify this scenario by simulating a Pydantic v2 style error during agent loading. Existing tests for other error types (SyntaxError, NameError) within agent code have been updated to reflect the new
RuntimeErrorwrapping behavior of the AgentLoader.Fixes #1227