-
Notifications
You must be signed in to change notification settings - Fork 183
Revamp overall report UI and improve report navigation #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you post screenshots?
IMO on thing that we should watch out for is losing overview ability for the benefit of more modern-looking UI. Following #1062 I think it's more difficult to traverse the benchmarks on a higher level, probably because we have significantly reduced the amount of benchmarks shown on the screen at once. I find when experiments have hundreds of benchmarks it's convenient to have a lot of data shown at once.
Thank you for your feedback @DavidKorczynski! Do you think making all benchmarks shown as open by default would help in this regard? Currently their default behaviour is collapsed unless you clicked the 'Expand All' button or their corresponding project. Alternatively, would a dedicated table for benchmarks without grouping to projects, similar to the old report, be more helpful? It can exist alongside the current nested 'Project Summary' tables, like this: Here are the screenshots:
|
The UI looks great, thanks for sharing the screenshots.
The default is okay as is now.
Yeah I think this is what we need. A table (can be on a separate page or w/e, just that it's accessible) with minimal whitespace and ability to see a lot of benchmarks at once, similar to previously. |
This PR overhauls the overall report UI (layout and template/sample pages) and adds a few improvements including: