-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix Reload Mode when using gr.render #11338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/d21ffffb129171542fdc29a6bd93a0551f6be76c/gradio-5.33.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d21ffffb129171542fdc29a6bd93a0551f6be76c#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/d21ffffb129171542fdc29a6bd93a0551f6be76c/gradio-client-1.15.1.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d21ffffb129171542fdc29a6bd93a0551f6be76c/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
23b789d
to
807dda2
Compare
25aab2a
to
de807b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks @freddyaboulton !
Thank you so much @aliabid94 ! |
Description
Closes: #10199 . You can run repro in issue.
gr.render + reload mode was not working at all.
Two reasons:
@gr.render
output gets placed was not in theinstance_map
.@gr.render
would fire withundefined
for the component value since the load event was triggering before the components were added to the_component_map
.When the page re-renders based on file changes, the
gr.render
event still triggers. We could fix this in a separate PR.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh