Frankenstein - do not merge #265
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for what we'd need to do to backport the v2 update for cloudwatch to grafana 11.4.X. It's kind of terrible but it works. It pairs with the corresponding PR in grafana/grafana: grafana/grafana#107788
The issue with backporting this is that the v2 update depends on newer code in grafana-aws-sdk and grafana-plugin-sdk-go, but 11.4 is not compatible with these newer versions. This PR chops both libraries up and hacks them together, exposing under a different package only what cloudwatch v2 needs, to avoid import conflicts with our libraries and minimize the number of downstream dependency updates.