Skip to content

Page.WaitForRequest #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 27, 2025
Merged

Page.WaitForRequest #5330

merged 13 commits into from
Oct 27, 2025

Conversation

@inancgumus
Copy link
Contributor

What?

Adds Page.WaitForRequest waits for a request that matches the provided URL pattern. Along with this work, we've also revamped the page event handling system to make adding features like this one easier.

Why?

To boost Playwright compatibility, reduce flaky tests, and give users more control.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@inancgumus inancgumus changed the base branch from master to add/page-wait-for-event October 22, 2025 14:15
@inancgumus inancgumus added this to the v1.4.0 milestone Oct 22, 2025
@inancgumus inancgumus self-assigned this Oct 22, 2025
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 22, 2025 14:21 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 22, 2025 14:23 — with GitHub Actions Inactive
Base automatically changed from add/page-wait-for-event to master October 24, 2025 14:16
@inancgumus inancgumus force-pushed the add/page-wait-for-request branch from 791a58f to eeee3ce Compare October 24, 2025 14:24
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 14:30 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 14:32 — with GitHub Actions Inactive
@inancgumus inancgumus force-pushed the add/page-wait-for-request branch from eeee3ce to 46af187 Compare October 24, 2025 15:59
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 16:05 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 16:07 — with GitHub Actions Inactive
@inancgumus inancgumus force-pushed the add/page-wait-for-request branch from 46af187 to 7c6c852 Compare October 24, 2025 16:08
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 16:14 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 16:16 — with GitHub Actions Inactive
@inancgumus inancgumus marked this pull request as ready for review October 24, 2025 16:36
@inancgumus inancgumus requested a review from a team as a code owner October 24, 2025 16:36
@inancgumus inancgumus requested review from codebien and removed request for a team October 24, 2025 16:36
@inancgumus inancgumus requested a review from joanlopez October 24, 2025 16:36
@inancgumus inancgumus force-pushed the add/page-wait-for-request branch from 7c6c852 to 7628d9e Compare October 24, 2025 17:37
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 17:43 — with GitHub Actions Inactive
@inancgumus inancgumus temporarily deployed to azure-trusted-signing October 24, 2025 17:45 — with GitHub Actions Inactive
codebien
codebien approved these changes Oct 27, 2025
View reviewed changes
@inancgumus inancgumus merged commit fe55955 into master Oct 27, 2025
46 of 47 checks passed
@inancgumus inancgumus deleted the add/page-wait-for-request branch October 27, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebien codebien codebien approved these changes

@joanlopez joanlopez joanlopez approved these changes

Assignees

@inancgumus inancgumus

Labels

area: browser feature

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

Implement Page.waitForRequest(urlOrPredicate[, options])

3 participants

@inancgumus @codebien @joanlopez