Skip to content

Conversation

kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented Aug 7, 2025

Fixes: #360

The flaky alert e2e test was frustrating. I found this comment I left when adding the playwright tests #358 (comment). And on two separate runs, none of the e2e tests have failed.

Empty queries have the run button disabled

empty query

Run button is enabled when query isn't empty

query

@kevinwcyu kevinwcyu requested a review from a team as a code owner August 7, 2025 01:05
@kevinwcyu kevinwcyu requested review from iwysiu and idastambuk and removed request for a team August 7, 2025 01:06
@idastambuk idastambuk merged commit c554dff into main Aug 29, 2025
18 checks passed
@idastambuk idastambuk deleted the kevinwcyu/remove-onblur-sqleditor branch August 29, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not run the query on blur
3 participants