-
Notifications
You must be signed in to change notification settings - Fork 4
Allow anonymous admins to use admin scoped commands #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carafelix can you please TAL at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really glad to see this PR. A well thought addition.
Requested changes are mostly about unused lines.
I think lines 1030-1032 need an explanation or change.
Thanks for checking out on this.
Remove `from` field when `sender_chat` is specified in test Co-authored-by: Hero Protagonist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the further explanations
Currently anonymous admins are unable to use admin scoped commands, despite them being displayed in the user interface. The docs say about sender_chat:
There should be no other way to send a message on behalf of a group.
This pull request updates the
isAdmin
function to take into account anonymous admins.