Skip to content

Disable affine option for LearnedTask #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Disable affine option for LearnedTask #782

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17c9707
New option to disable affine layer
pweigel Jan 22, 2025
a054707
Formatting
pweigel Jan 22, 2025
0c409bc
Fix docstring
pweigel Jan 22, 2025
43d5e66
Fix mistake in logic, use Identity instead of None
pweigel Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/graphnet/models/task/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import torch
from torch import Tensor
from torch.nn import Linear
from torch.nn import Linear, Identity
from torch_geometric.data import Data

if TYPE_CHECKING:
Expand Down Expand Up @@ -235,6 +235,7 @@ def __init__(
self,
hidden_size: int,
loss_function: "LossFunction",
disable_affine: bool = False,
**task_kwargs: Any,
):
"""Construct `LearnedTask`.
Expand All @@ -244,18 +245,23 @@ def __init__(
the last latent layer of `Model` using this Task.
Available through `Model.nb_outputs`
loss_function: Loss function appropriate to the task.
disable_affine: Disable linear layer mapping from hidden layer size
to number of inputs.
"""
# Base class constructor
super().__init__(**task_kwargs)

# Mapping from last hidden layer to required size of input
self._loss_function = loss_function
self._affine = Linear(hidden_size, self.nb_inputs)
self._disable_affine = disable_affine

if self._disable_affine:
self._affine = Identity()
else:
self._affine = Linear(hidden_size, self.nb_inputs)

@abstractmethod
def _forward( # type: ignore
self, x: Union[Tensor, Data]
) -> Union[Tensor, Data]:
def _forward(self, x: Union[Tensor, Data]) -> Union[Tensor, Data]:
"""Syntax like `.forward`, for implentation in inheriting classes."""
raise NotImplementedError

Expand All @@ -272,9 +278,7 @@ def nb_inputs(self) -> int:
"""Return number of inputs assumed by task."""

@final
def forward( # type: ignore
self, x: Union[Tensor, Data]
) -> Union[Tensor, Data]:
def forward(self, x: Union[Tensor, Data]) -> Union[Tensor, Data]:
"""Forward call for `LearnedTask`.

The learned embedding transforms last latent layer of Model to meet
Expand Down