RFC: incremental delivery with deduplication + concurrent execution #1034
+1,969
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Section 3 -- Type System.md Update Section 3 -- Type System.md Update Section 3 -- Type System.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Update Section 6 -- Execution.md Amend changes change initial_count to initialCount add payload fields to Response section add stream validation for overlapping fields spelling updates add note about re-execution add note about final payloads label is optional fix build Update ExecuteQuery with hasNext logic fix spelling fix spaces Update execution to add defer/stream to mutations and subscriptions clarify stream records Apply suggestions from code review Co-authored-by: Benjie Gillam <[email protected]> missing bracket Update spec/Section 7 -- Response.md Co-authored-by: Benjie Gillam <[email protected]> clarify line about stream record iterator update visitedFragments with defer Updates to consolidate subsequent payload logic for queries, mutations, and subscriptions Apply suggestions from code review Co-authored-by: Benjie Gillam <[email protected]> address review feedback Add handling of termination signal more formatting fix spelling Add assertion for record type add "Stream Directives Are Used On List Fields" validation rule Add defaultValue to @stream initialCount Update spec/Section 5 -- Validation.md Co-authored-by: Benjie Gillam <[email protected]> # Conflicts: # spec/Section 3 -- Type System.md # spec/Section 5 -- Validation.md # spec/Section 6 -- Execution.md # spec/Section 7 -- Response.md
# Conflicts: # spec/Section 3 -- Type System.md
# Conflicts: # spec/Section 3 -- Type System.md
# Conflicts: # spec/Section 3 -- Type System.md
# Conflicts: # spec/Section 3 -- Type System.md
# Conflicts: # spec/Section 7 -- Response.md
# Conflicts: # spec/Section 3 -- Type System.md # spec/Section 6 -- Execution.md
# Conflicts: # spec/Section 7 -- Response.md
# Conflicts: # spec/Section 6 -- Execution.md
# Conflicts: # spec/Section 6 -- Execution.md
# Conflicts: # spec/Section 6 -- Execution.md
…ators # Conflicts: # spec/Section 6 -- Execution.md
yaacovCR
force-pushed
the
deduplicate2
branch
4 times, most recently
from
805ef0a to
5f204c2
Compare
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jul 16, 2023
yaacovCR
force-pushed
the
deduplicate2
branch
10 times, most recently
from
d337917 to
f6a36c8
Compare
yaacovCR
force-pushed
the
deduplicate2
branch
5 times, most recently
from
7f6c04d to
4e80aaa
Compare
only the Incremental Publisher subroutines need to maintain records
|
Closing in favor of #1052 |
benjie
added
the
🌱 Superseded (RFC X)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1026
This version sets up an Incremental Publisher Record that includes:
(a) an Execution Event Queue input stream on the and
(b) a Subsequent Result output stream.
No mutations happen outside the algorithms that define any records.
With the following caveats:
CreateIncrementalPublisher()algorithm is where the magic happens, a long algorithm where the Execution Event Handler and lazily executed Subsequent Result stream are managed concurrently. To increase readability, several subprocedures/macros/inner functions are defined that have access to the variables defined within the entire algorithm.