show an example of the -I option #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crpb
reviewed
Oct 3, 2025
anarcat
force-pushed
the
dash-i
branch
2 times, most recently
from
bdb0a5f to
c7ffa6b
Compare
mika
reviewed
Oct 3, 2025
I have found that section to be difficult to read, at best. I had to read the code block a few times to even understand what it did - why do we need GRML_FAI_CONFIG in here? Assuming all this is unnecessary, it seems much easier to do overlays directly on the grml-live commandline with -I. So let's show that! We still refer to the CHROOT_INSTALL (configuration) variable there so power users can write that in their configuration files, of course.
|
okay, i squashed the commits and tweaked the first line! |
zeha
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that section to be difficult to read, at best. I feel the example could be dramatically simplified there - why do we need GRML_FAI_CONFIG in here?
But regardless, it seems there's also a much easier way to do this than having to hack at a config file: you can (i think?) pass extra such overlays directly on the grml-live commandline with -I.
So let's show that!