Skip to content

[Issue 20] Fix logger performance regression #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2025
Merged

[Issue 20] Fix logger performance regression #21

merged 3 commits into from
Jul 13, 2025

Conversation

HugoKlepsch
Copy link
Contributor

  • Fixes Performance regression from 1.3.4 to 1.3.5 #20
  • This PR is split into three commits:
    • Add a load test that fails (still affected by performance regression)
    • Fix performance regression -- tests now pass
    • Fix some weird assertions I saw (technically unrelated)

Fix performance regression caused by adding logger handler N times

Fix some comparisons in assertions

  • Numbers should be compared with == unless you really want to compare the underlying object references.

@HugoKlepsch
Copy link
Contributor Author

I should mention, the tests pass:

$ python test_retrying.py
[...]
...................
----------------------------------------------------------------------
Ran 27 tests in 24.470s

OK

@HugoKlepsch
Add performance regression test for retry decorator
f08e1a0 
* Test for groodt#20
@HugoKlepsch
Fix performance regression caused by configuring logger handler N times
1c296f8 
* Test for groodt#20
* Added tests covering paths for configuring default or null logger.
* Now passes the load test.
* Added myself to contributors.
@HugoKlepsch
Fix some comparisons in assertions in test_retrying.py
6f9a7b6 
* Numbers should be compared with `==` unless you really want to compare the underlying object references.
@HugoKlepsch HugoKlepsch force-pushed the issue-20-fix-logger-perf-regression branch from d691d3a to 6f9a7b6 Compare July 10, 2025 12:11
groodt
groodt approved these changes Jul 13, 2025
View reviewed changes
Copy link
Owner

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit b772b26 into groodt:main Jul 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression from 1.3.4 to 1.3.5
2 participants
@HugoKlepsch @groodt