Skip to content

Conversation

splattael
Copy link
Contributor

@splattael splattael commented Sep 1, 2022

This PR supersedes #189.

It:

  • Drops travis 😢
  • Adds GitHub workflows
  • Tests on Ruby 2.75, 3.0, 3.1 with Rails 5.2, 6.1, and 7.0
  • Uses end_with?
  • Removes workaround for hamit for Ruby 1.9/2.0

@splattael
Copy link
Contributor Author

👋 @grosser

Do you mind reviewing this PR? 🙏

Please bear with me as I am a GitHub workflow newbie 😅

@splattael splattael force-pushed the ruby-3 branch 3 times, most recently from b0a00fe to daf2e54 Compare September 1, 2022 10:37
We are testing on Ruby 2.7.5, 3.0 and 3.1 with Rails 5.2, 6.1 and 7.0.

Ruby 3.x doesn't work with Rails 5.2.
Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@grosser grosser merged commit 59f62ab into grosser:master Sep 1, 2022
@grosser
Copy link
Owner

grosser commented Sep 1, 2022

FYI tiny cleanup #191 + helper to bundle all gemfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants