-
Notifications
You must be signed in to change notification settings - Fork 30
Marketing email promotions #14051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dblatcher
wants to merge
10
commits into
main
Choose a base branch
from
dblatcher-jobs-email-promotion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Marketing email promotions #14051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent function, if article has a magic tag
… version of the email signup wrapper
…nto dblatcher-jobs-email-promotion
Size Change: +144 B (+0.01%) Total Size: 1.04 MB ℹ️ View Unchanged
|
…nto dblatcher-jobs-email-promotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
MarketingEmailSignUpWrapper
to represent the element - mostly using the same sub-components at the existingEmailSignUpWrapper
- but rendering a link to the mma /email-prefs page instead of a sign-up form.MarketingEmailSignUpWrapper
andEmailSignUpWrapper
enhanceNewsletterSignup
function to check for tags corresponding to marketing emails and insert a "MarketingEmailSignupBlockElement"MarketingConsentEmail
representing those hard-coded into the identity repoThis PR would currently have no user-facing effects as non of the defined
MarketingConsentEmail
have the "promotionTagId" property.Why?
There's a long-standing request from the Guardian jobs team in-article promotions for the Guardian Job marketing email, that would work in substantially the same way as the existing sign-up blocks for editorial newsletters ie:
This PR provides a mechanism to allowing that - when a tag is created to promote a marketing email, its Id can be added to the object describing the email in DCR.
Future work
MarketingConsentEmail
s when a pattern/convention is agreed (these are likely to be campaign tags of some sort rather than existing keyword or sectioning tags)Screenshots