-
Notifications
You must be signed in to change notification settings - Fork 30
Add Editions Crosswords To Pages Router #14095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a general suggestion
pages.get( | ||
'/editions-crosswords', | ||
sendReact('Editions Crosswords', EditionsCrosswords), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading through the /editions-crosswords page but it doesn't have any link to go to the crossword page. Since the edition crosswords in general not super clear for me, I think this might be the case for others as well, and it might be worth adding more details.
Is that http://localhost:3030/EditionsCrossword that we can use locally? I can see that in get-content-from-url file it's supposed to get the content from https://www.theguardian.com/crosswords/digital-edition.json?dcr=true but why this url doesn't return anything?
Seen on PROD (merged by @JamieB-gu 8 minutes and 51 seconds ago) Please check your changes! |
Missed in #13974, part of #13737.