-
Notifications
You must be signed in to change notification settings - Fork 30
Signed in user e2e test #14109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arelra
wants to merge
9
commits into
main
Choose a base branch
from
ravi/e2e-test-signed-in-user-iii
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Signed in user e2e test #14109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to `signed-out.e2e.spec.ts`
- creates a test user via the IDAPI test endpoint - sets user cookies - relies on third party cookies enabled by default in Playwright to work
…lso in CI This is used by identity libraries to determine whether to use CODE or PROD endpoints
…sts i.e *.e2e.spec.ts
- setups secure server - runs *.e2e.secure.spec.ts tests
Size Change: +20 B (0%) Total Size: 1.05 MB ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the capability to:
The flow for signing in a user is as follows:
IDAPI_CLIENT_ACCESS_TOKEN
GU_U
cookieThe sign-in flow requires DCR to be run on a known secure server, hence this change also adds setup on CI for the server
https://r.gulocal.com
.Regular e2e tests and secure tests are distinguished by the test filename postfix of:
The above file patterns are used as filters for the the workflows
playwright.yml
andplaywright-secure.yml
Why?
Since the move to Okta we have lost the ability to test sign-in flows.
This change restores that capability.
Notes
This test introduces a dependency on CODE infrastructure which we need to monitor. Identity's e2e tests also rely on the same CODE endpoints so there is some existing load but DCR's tests will increase the request volume to that endpoint.
We'll need to monitor this test for any flakiness.
If the complexity of maintaining this test outweighs its usefulness then we can revert.
Screenshots
e2e-signed-in-02.mp4