Resume looping video when re-enters viewport #14133
Merged
+130
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Size Change: +380 B (+0.04%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
Jun 26, 2025
| // not want videos to play automatically, e.g. prefers reduced motion. Otherwise, | ||
| // we do not need to download the image as the video will be autoplayed. | ||
| const posterImage = | ||
| !!prefersReducedMotion || isInView === false |
There was a problem hiding this comment.
why do we need to grab the image if the video is not in view?
There was a problem hiding this comment.
For this situation, where the second card has a blank space in the place of the video:
A little confusing, as isInView means is at least 50% in view. I wonder if there's a better name for this variable
abeddow91
approved these changes
Jun 26, 2025
| 'PAUSED_BY_USER', | ||
| 'PAUSED_BY_INTERSECTION_OBSERVER', | ||
| ] as const; | ||
|
|
There was a problem hiding this comment.
I really like this type, it makes the intent of the loop video very easy to follow.
|
Seen on PROD (merged by @domlander 8 minutes and 53 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
useIsInViewto be able to know for certain whether an element it out of view. This is helpful because we don't want to display (and therefore download) the poster image if the video is in view and will autoplay.hasAudiocheck. We don't yet receive this flag.webmoption. This is not yet implemented and we will only receive mp4 files for now.Why?
Minor bug fixes, code quality improvement
Screenshots
Play muted video when 50% of player re-enters viewport
Screen.Recording.2025-06-25.at.16.24.42.mov
Prefers reduced motion: ON
Screen.Recording.2025-06-25.at.16.27.22.mov