Add gallery sub meta #14137
Open
Add gallery sub meta #14137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jamie B <[email protected]>
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +8 B (0%) Total Size: 1.05 MB ℹ️ View Unchanged
|
SiAdcock
reviewed
Jun 26, 2025
| @@ -184,7 +193,8 @@ export const SubMeta = ({ | |||
| /> | |||
| </Island> | |||
| <div css={syndicationButtonOverrides}> | |||
| {format.design === ArticleDesign.Interactive ? null : ( | |||
| {format.design === ArticleDesign.Interactive || | |||
| format.design === ArticleDesign.Gallery ? null : ( | |||
There was a problem hiding this comment.
Nit: I know this is not something introduced here, but what do you think about moving this check outside the enclosing <div>?
There was a problem hiding this comment.
Just wading in here with a comment on this component, and maybe other standard page furniture components 💃
Ideally I think we could do away with the need for components like the <SubMeta> to know about the context in which they are used. This invites the component to become unwieldy, as it offers a pattern for making many tiny variations to the design based on context.
In this case, we could pass a prop to flag whether to show / hide the syndication button.
This question needn't block this PR, and perhaps there is a better forum for a discussion like this. I'd be interested to hear your opinions @marjisound and @JamieB-gu, and anyone else who happens to read!
SiAdcock
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @JamieB-gu
What does this change?
This PR does the following: