Mute other Looping Videos when playing audio #14142
Open
+226
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +224 B (+0.02%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
domlander
added
fronts + curation
run_chromatic
domlander
commented
Jun 26, 2025
| @@ -81,6 +81,15 @@ export const decideCardPositions = (cards: DCRFrontCard[]): GroupedCards => { | |||
| }, []); | |||
| }; | |||
|
|
|||
| type ImmersiveCardLayoutProps = { | |||
There was a problem hiding this comment.
I've extracted the Props out into their own types for a few components here, to meet convention.
github-actions
bot
removed
the
run_chromatic
domlander
commented
Jun 26, 2025
| const isLoopingVideo = card.mainMedia?.type === 'LoopVideo'; | ||
|
|
||
| return ( | ||
| <UL padBottom={true} key={card.url}> | ||
| <UL padBottom={true}> |
There was a problem hiding this comment.
I misunderstood how keys work in a previous PR. The should be added to the first child inside the map, even if that is a Component.
domlander
commented
Jun 26, 2025
| @@ -593,8 +597,16 @@ export const FlexibleGeneral = ({ | |||
| collectionId, | |||
| isInHideTrailsAbTest, | |||
| }: Props) => { | |||
| const splash = [...groupedTrails.splash].slice(0, 1); | |||
| const cards = [...groupedTrails.standard].slice(0, 19); | |||
| const splash = [...groupedTrails.splash].slice(0, 1).map((snap) => ({ | |||
There was a problem hiding this comment.
Given how we store cards in separate groupings (e.g. splash) and find them from curated and backfill, it was very fiddly to apply a unique index above this component.
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
UX improvement. Two videos playing audio at the same time is almost never desirable and is disorientating.
Screenshots
It's quite small, but the audio icon flicks from "sound" to "muted" state, when a different video has audio enabled.
Screen.Recording.2025-06-26.at.16.35.51.mov